Skip to content

Commit

Permalink
Breaking Change: Dropped support for Ruby DSL, [as previously announc…
Browse files Browse the repository at this point in the history
…ed](https://engdoc.corp.google.com/eng/doc/devguide/proto/news/2023-12-27.md#ruby-breaking-changes).

The generated code has not used the DSL since 23.0 (released May 8, 2023).

PiperOrigin-RevId: 595481605
  • Loading branch information
haberman authored and copybara-github committed Jan 3, 2024
1 parent f00fc70 commit 5cfc9e7
Show file tree
Hide file tree
Showing 21 changed files with 134 additions and 785 deletions.
15 changes: 0 additions & 15 deletions ruby/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -229,21 +229,6 @@ filegroup(
# Tests
################################################################################

# Define this here so the descriptor paths match what we get in Rake tests.
internal_ruby_proto_library(
name = "test_ruby_protos",
srcs = ["//ruby/tests:test_protos"],
includes = [
".",
"ruby/tests",
"src",
],
visibility = [
"//ruby:__subpackages__",
],
deps = [":well_known_ruby_protos"],
)

conformance_test(
name = "conformance_test",
failure_list = "//conformance:failure_list_ruby.txt",
Expand Down
4 changes: 3 additions & 1 deletion ruby/Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ test_protos = %w[
tests/generated_code.proto
tests/generated_code_proto2.proto
tests/multi_level_nesting_test.proto
tests/repeated_field_test.proto
tests/stress.proto
tests/test_import.proto
tests/test_import_proto2.proto
tests/test_ruby_package.proto
Expand Down Expand Up @@ -64,7 +66,7 @@ unless ENV['IN_DOCKER'] == 'true' or ENV['BAZEL'] == 'true'
output_file = proto_file.sub(/\.proto$/, "_pb.rb")
genproto_output << output_file
file output_file => proto_file do |file_task|
sh "#{protoc_command} -I../src -I. -I./tests --ruby_out=. #{proto_file}"
sh "#{protoc_command} -I../src -I./tests --ruby_out=tests #{proto_file}"
end
end
end
Expand Down
Loading

0 comments on commit 5cfc9e7

Please sign in to comment.