Skip to content

Commit

Permalink
Apply PROTOBUF_NOINLINE to declarations of some functions that want it.
Browse files Browse the repository at this point in the history 
Clang's ThinLTO does not know to honor __attribute__((noinline)) on the
definition in a .cc file if the declaration in a .h file did not also have the
attribute.  This can lead to unwanted cross-translation-unit inlining
contributing to stack overflow in deeply recursive protobuf parses, but only
in sufficiently vigorously optimized release builds.

PiperOrigin-RevId: 573266335
  • Loading branch information
@protobuf-github-bot @copybara-github
protobuf-github-bot authored and copybara-github committed Oct 13, 2023
1 parent ec57ed7 commit 6e848b0
Show file tree
Hide file tree
Showing 2 changed files with 140 additions and 128 deletions.
Loading

0 comments on commit 6e848b0

Please sign in to comment.