Skip to content

Commit

Permalink
Bump abseil dependency version from 20230802.1 to 20240722.0.
Browse files Browse the repository at this point in the history
See abseil release notes:
https://github.com/abseil/abseil-cpp/releases/tag/20240722.0

This is necesary pre-work to enable C++17 builds in preparation of baseline C++
upgrade from C++14 to C++17. C++14 support is scheduled to reach EOL on
2024-12-15:
https://github.com/google/oss-policies-info/blob/main/foundational-cxx-support-matrix.md

Interestingly enough, the older Abseil version 20230802.1 is actually OK for
building on macOS with C++17. However, we depend on GoogleTest, and they
transitively depend on Abseil version 20240116.2, which caused Bazel to
implicitly change the Abseil dependency to most recent specified version of
20240116.2:
https://github.com/google/googletest/blob/main/MODULE.bazel

Current builds with C++17 and Abseil version 20240116.2 on older macos versions
that didn't support `std::filesystem::path` would give the following error:

> error: 'path' is unavailable: introduced in macOS 10.15.

With this version upgrade, we pull in an Abseil patch that fixes this issue on
macOS:
abseil/abseil-cpp@65a55c2
PiperOrigin-RevId: 686670268
  • Loading branch information
tonyliaoss authored and copybara-github committed Oct 16, 2024
1 parent 09af1d8 commit c75095b
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 35 deletions.
2 changes: 1 addition & 1 deletion MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ module(
# Bzlmod follows MVS:
# https://bazel.build/versions/6.0.0/build/bzlmod#version-resolution
# Thus the highest version in their module graph is resolved.
bazel_dep(name = "abseil-cpp", version = "20230802.1", repo_name = "com_google_absl")
bazel_dep(name = "abseil-cpp", version = "20240722.0", repo_name = "com_google_absl")
bazel_dep(name = "bazel_skylib", version = "1.7.0")
bazel_dep(name = "jsoncpp", version = "1.9.5")
bazel_dep(name = "rules_cc", version = "0.0.13")
Expand Down
34 changes: 0 additions & 34 deletions cmake/dependencies.cmake

This file was deleted.

0 comments on commit c75095b

Please sign in to comment.