Skip to content

cmake build does not install {go,java}_features.proto #19735

Closed
@jrick

Description

What version of protobuf and what language are you using?
Version: 29.1

What operating system (Linux, Windows, ...) and version?

Observed on both OpenBSD and Linux.

What runtime / compiler are you using (e.g., python version or gcc version)

n/a

What did you do?
Steps to reproduce the behavior:

  1. build and install using cmake rather than bazel.

What did you expect to see

The same installed files as in the official zip release

What did you see instead?

Installation is missing go_features.proto and java_features.proto is installed to the wrong location.

From cmake build:

$ find . | grep .proto$
./include/google/protobuf/compiler/plugin.proto
./include/google/protobuf/any.proto
./include/google/protobuf/wrappers.proto
./include/google/protobuf/field_mask.proto
./include/google/protobuf/duration.proto
./include/google/protobuf/cpp_features.proto
./include/google/protobuf/descriptor.proto
./include/google/protobuf/timestamp.proto
./include/google/protobuf/source_context.proto
./include/google/protobuf/type.proto
./include/google/protobuf/api.proto
./include/google/protobuf/struct.proto
./include/google/protobuf/empty.proto
./include/java/core/src/main/resources/google/protobuf/java_features.proto

Compared to the extracted .zip:

$ find . | grep .proto$                                                        
./include/google/protobuf/any.proto
./include/google/protobuf/api.proto
./include/google/protobuf/compiler/plugin.proto
./include/google/protobuf/cpp_features.proto
./include/google/protobuf/descriptor.proto
./include/google/protobuf/duration.proto
./include/google/protobuf/empty.proto
./include/google/protobuf/field_mask.proto
./include/google/protobuf/go_features.proto
./include/google/protobuf/java_features.proto
./include/google/protobuf/source_context.proto
./include/google/protobuf/struct.proto
./include/google/protobuf/timestamp.proto
./include/google/protobuf/type.proto
./include/google/protobuf/wrappers.proto

Anything else we should know about your project / environment

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions