Bazelify ruby runtime #10525
Closed
Bazelify ruby runtime #10525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkruskal-google
added
ruby
bazel
release notes: no
jruby
JasonLunn
requested changes
Sep 8, 2022
mkruskal-google
force-pushed
the
rules_ruby
branch
4 times, most recently
from
77283e2 to
c4ea6f7
Compare
mkruskal-google
force-pushed
the
rules_ruby
branch
from
c4ea6f7 to
af19b32
Compare
mkruskal-google
force-pushed
the
rules_ruby
branch
3 times, most recently
from
12a60d0 to
61f2190
Compare
mkruskal-google
force-pushed
the
rules_ruby
branch
7 times, most recently
from
5d70c6f to
0ece600
Compare
mkruskal-google
force-pushed
the
rules_ruby
branch
from
0ece600 to
98c2053
Compare
mkruskal-google
force-pushed
the
rules_ruby
branch
from
de993b2 to
fbbd96b
Compare
copybara-service bot
pushed a commit
that referenced
this pull request
Dec 27, 2022
This uses https://github.com/protocolbuffers/rules_ruby to fully Bazelify our ruby runtime code. The Rakefile is left in place for now and is still used by our aarch64 tests. With the current implementation ruby behaves similarly to our python wrapper, which selects whatever version is installed in the system. Future enhancements will allow for more hermetic builds via Bazel flags to pin a specific version Closes #10525 COPYBARA_INTEGRATE_REVIEW=#10525 from mkruskal-google:rules_ruby 97fa1f7 FUTURE_COPYBARA_INTEGRATE_REVIEW=#10525 from mkruskal-google:rules_ruby 97fa1f7 PiperOrigin-RevId: 498031251
copybara-service bot
pushed a commit
that referenced
this pull request
Dec 29, 2022
This uses https://github.com/protocolbuffers/rules_ruby to fully Bazelify our ruby runtime code. The Rakefile is left in place for now and is still used by our aarch64 tests. With the current implementation ruby behaves similarly to our python wrapper, which selects whatever version is installed in the system. Future enhancements will allow for more hermetic builds via Bazel flags to pin a specific version Closes #10525 COPYBARA_INTEGRATE_REVIEW=#10525 from mkruskal-google:rules_ruby 97fa1f7 FUTURE_COPYBARA_INTEGRATE_REVIEW=#10525 from mkruskal-google:rules_ruby 97fa1f7 PiperOrigin-RevId: 498031251
copybara-service bot
pushed a commit
that referenced
this pull request
Dec 29, 2022
This uses https://github.com/protocolbuffers/rules_ruby to fully Bazelify our ruby runtime code. The Rakefile is left in place for now and is still used by our aarch64 tests. With the current implementation ruby behaves similarly to our python wrapper, which selects whatever version is installed in the system. Future enhancements will allow for more hermetic builds via Bazel flags to pin a specific version Closes #10525 COPYBARA_INTEGRATE_REVIEW=#10525 from mkruskal-google:rules_ruby 97fa1f7 FUTURE_COPYBARA_INTEGRATE_REVIEW=#10525 from mkruskal-google:rules_ruby 97fa1f7 PiperOrigin-RevId: 498031251
copybara-service bot
pushed a commit
that referenced
this pull request
Dec 29, 2022
This uses https://github.com/protocolbuffers/rules_ruby to fully Bazelify our ruby runtime code. The Rakefile is left in place for now and is still used by our aarch64 tests. With the current implementation ruby behaves similarly to our python wrapper, which selects whatever version is installed in the system. Future enhancements will allow for more hermetic builds via Bazel flags to pin a specific version Closes #10525 COPYBARA_INTEGRATE_REVIEW=#10525 from mkruskal-google:rules_ruby 97fa1f7 FUTURE_COPYBARA_INTEGRATE_REVIEW=#10525 from mkruskal-google:rules_ruby 97fa1f7 PiperOrigin-RevId: 498031251
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 3, 2023
This uses https://github.com/protocolbuffers/rules_ruby to fully Bazelify our ruby runtime code. The Rakefile is left in place for now and is still used by our aarch64 tests. With the current implementation ruby behaves similarly to our python wrapper, which selects whatever version is installed in the system. Future enhancements will allow for more hermetic builds via Bazel flags to pin a specific version Closes #10525 COPYBARA_INTEGRATE_REVIEW=#10525 from mkruskal-google:rules_ruby 97fa1f7 FUTURE_COPYBARA_INTEGRATE_REVIEW=#10525 from mkruskal-google:rules_ruby 97fa1f7 PiperOrigin-RevId: 498031251
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses https://github.com/protocolbuffers/rules_ruby to fully Bazelify our ruby runtime code. The Rakefile is left in place for now and is still used by our aarch64 tests. With the current implementation ruby behaves similarly to our python wrapper, which selects whatever version is installed in the system. Future enhancements will allow for more hermetic builds via Bazel flags to pin a specific version