protoc: support identifiers as reserved names in addition to string literals (only in editions) #13471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkruskal-google
added
protoc
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
|
Np, thanks Joshua! |
|
After discussing this a bit with the team, I think we can make this a stronger condition. Under editions, we can require the new syntax, since there's a simple no-op transformation for prototiller to upgrade to during the edition migration |
Ah, very good idea! I'll have that change pushed pretty soon. |
|
@mkruskal-google, I think this is ready for another look. Editions now requires identifiers. The error message for when a user gets it backwards (e.g. tries to use an identifier in proto2 or proto3 or a string literal in editions) should be very clear now, too. |
mkruskal-google
added
the
🅰️ safe for tests
mkruskal-google
approved these changes
Aug 9, 2023
github-actions
bot
removed
the
🅰️ safe for tests
|
Awesome lgtm, thanks for the contribution! |
copybara-service bot
pushed a commit
that referenced
this pull request
Aug 10, 2023
…iterals (only in editions) (#13471) This addresses #13440. @mkruskal-google, I saw you are assigned the above issue. I hope it's okay that I took a stab at it. Closes #13471 COPYBARA_INTEGRATE_REVIEW=#13471 from jhump:jh/reserved-names-support-identifiers a23f18e FUTURE_COPYBARA_INTEGRATE_REVIEW=#13471 from jhump:jh/reserved-names-support-identifiers a23f18e PiperOrigin-RevId: 555559034
copybara-service bot
pushed a commit
that referenced
this pull request
Aug 10, 2023
…iterals (only in editions) (#13471) This addresses #13440. @mkruskal-google, I saw you are assigned the above issue. I hope it's okay that I took a stab at it. Closes #13471 COPYBARA_INTEGRATE_REVIEW=#13471 from jhump:jh/reserved-names-support-identifiers a23f18e FUTURE_COPYBARA_INTEGRATE_REVIEW=#13471 from jhump:jh/reserved-names-support-identifiers a23f18e PiperOrigin-RevId: 555559034
copybara-service bot
pushed a commit
that referenced
this pull request
Aug 10, 2023
…iterals (only in editions) (#13471) This addresses #13440. @mkruskal-google, I saw you are assigned the above issue. I hope it's okay that I took a stab at it. Closes #13471 COPYBARA_INTEGRATE_REVIEW=#13471 from jhump:jh/reserved-names-support-identifiers a23f18e FUTURE_COPYBARA_INTEGRATE_REVIEW=#13471 from jhump:jh/reserved-names-support-identifiers a23f18e PiperOrigin-RevId: 555559034
jhump
added a commit
to bufbuild/protocompile
that referenced
this pull request
Aug 23, 2023
…es (#176) This implements the use of identifiers, instead of string literals, in `reserved` statements. This new syntax is for editions; proto2 and proto3 continue to use string literals for backwards compatibility. This effectively ports protocolbuffers/protobuf#13471 to protocompile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #13440.
@mkruskal-google, I saw you are assigned the above issue. I hope it's okay that I took a stab at it.