Add back android config_setting that looks for //external:android/crosstool #16127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sifmelcara
force-pushed
the
add-back-legacy-crosstool-top
branch
from
ee3d045 to
8ce8bca
Compare
acozzette
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
acozzette
requested changes
Mar 12, 2024
…sstool In protocolbuffers#15298 `"crosstool_top": "//external:android/crosstool"` was replaced with `"crosstool_top": "@platforms//os:android"`. This breaks users who have not migrated to https://bazel.build/concepts/platforms yet.
sifmelcara
force-pushed
the
add-back-legacy-crosstool-top
branch
from
8ce8bca to
c643235
Compare
acozzette
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
acozzette
approved these changes
Mar 12, 2024
acozzette
pushed a commit
to acozzette/protobuf
that referenced
this pull request
Mar 21, 2024
…sstool (protocolbuffers#16127) In protocolbuffers#15298 `"crosstool_top": "//external:android/crosstool"` was replaced with `"crosstool_top": "@platforms//os:android"`. This breaks users who have not migrated to https://bazel.build/concepts/platforms yet. Closes protocolbuffers#16127 COPYBARA_INTEGRATE_REVIEW=protocolbuffers#16127 from sifmelcara:add-back-legacy-crosstool-top c643235 PiperOrigin-RevId: 615449874
acozzette
added a commit
that referenced
this pull request
Mar 22, 2024
…sstool (#16127) (#16264) In #15298 `"crosstool_top": "//external:android/crosstool"` was replaced with `"crosstool_top": "@platforms//os:android"`. This breaks users who have not migrated to https://bazel.build/concepts/platforms yet. Closes #16127 COPYBARA_INTEGRATE_REVIEW=#16127 from sifmelcara:add-back-legacy-crosstool-top c643235 PiperOrigin-RevId: 615449874 Co-authored-by: Ming-Chuan <[email protected]>
deannagarcia
pushed a commit
to deannagarcia/protobuf
that referenced
this pull request
Jun 20, 2024
…sstool (protocolbuffers#16127) In protocolbuffers#15298 `"crosstool_top": "//external:android/crosstool"` was replaced with `"crosstool_top": "@platforms//os:android"`. This breaks users who have not migrated to https://bazel.build/concepts/platforms yet. Closes protocolbuffers#16127 COPYBARA_INTEGRATE_REVIEW=protocolbuffers#16127 from sifmelcara:add-back-legacy-crosstool-top c643235 PiperOrigin-RevId: 615449874
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #15298
"crosstool_top": "//external:android/crosstool"was replaced with"crosstool_top": "@platforms//os:android". This breaks users who have not migrated to https://bazel.build/concepts/platforms yet.