Don't use CLOCK_UPTIME_RAW if it won't be defined #16951
Conversation
This will fix protocolbuffers#15957 by not trying to use CLOCK_UPTIME_RAW if the feature test macros are not currently set to make it available. Since the build system is in charge of the feature test macros, and since this header might be included under any end user program's build system, we can't just #define the macros we would like.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
I've had copyright for this contribution assigned from my employer to me personally, so I can sign the CLA for this contribution as an individual. |
|
I tried to do the CLA "rescan", and after completing the CAPTCHA I got an error:
|
|
@deannagarcia Are you able to rerun the CLA check for this? Also, how do I turn off the CLA for my Github account after this PR? I only have copyright on this contribution; any future PRs I make or other messages I send in the course of my employment are necessarily "not a contribution" under the agreement with me personally, unless/until I get copyright assigned to me personally for them specifically. |
|
@deannagarcia It looks like the inactivity bot has closed the associated issue #15957 due to there not being any progress on getting it fixed. When might you be available to review this PR? The CLA rescan still doesn't work, I think because the time to get the copyright assigned to me exceeded the time for which the "rescan" link in the CLA check was valid (it apparently expired on 2024-07-12). |
JasonLunn
added
c++
🅰️ safe for tests
JasonLunn
requested review from
acozzette
and removed request for
deannagarcia
github-actions
bot
removed
the
🅰️ safe for tests
acozzette
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
This will fix #15957 by not trying to use CLOCK_UPTIME_RAW if the feature test macros are not currently set to make it available. Since the build system is in charge of the feature test macros, and since this header might be included under any end user program's build system, we can't just #define the macros we would like. Closes #16951 COPYBARA_INTEGRATE_REVIEW=#16951 from adamnovak:patch-1 cebf44e FUTURE_COPYBARA_INTEGRATE_REVIEW=#16951 from adamnovak:patch-1 cebf44e PiperOrigin-RevId: 696207015
This will fix #15957 by not trying to use CLOCK_UPTIME_RAW if the feature test macros are not currently set to make it available.
Since the build system is in charge of the feature test macros, and since this header might be included under any end user program's build system, we can't just #define the macros we would like.