cmake: make DEPENDENCIES in protobuf_generate() a multi-value keyword #19175
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was previously a one-value keyword, so given
a
would be a dependency, andb
would be discarded (or, more precisely, added toprotobuf_generate_UNPARSED_ARGUMENTS
).This can be confirmed with the following changes:
Which printed "Deps: a" and "Unparsed args: b" for lite test files. With this change, it now prints "Deps: a;b" and "Unparsed args: ".
AFAIK, making
DEPENDENCIES
a multi-value keyword is mostly backwards-compatible; however, users who specified dependencies that were being ignored may be surprised to see that they are no longer ignored (which could cause build errors).To prevent this kind of problem in the future, validating that
protobuf_generate_UNPARSED_ARGUMENTS
is empty could be useful, but to avoid potentially breaking more builds I did not do this in this PR.