-
Notifications
You must be signed in to change notification settings - Fork 15.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performace of repeated packed fixedSize fields #19667
Improve performace of repeated packed fixedSize fields #19667
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
f30160d
to
8f87b3d
Compare
2823100
to
e5c3514
Compare
@YarinOmesi - can you rebase this PR to see if that clears up the test failures? |
5fd703d
to
7eda30c
Compare
Can you take a look at the failing C# conformance test?
|
There was a problem with reading bools with my approch because of .net marshaling stuff, so i added validation that comapre .net size and codec.FixedSize |
Changes
Improve performance of packed RepeatedField that has fixed size, by coping
LEN
bytes from serialzied buffer to RepeatedField array (like c memcpy).Relevant Information
As the docs here notes, fixed size value is
memcpy of the equivalent C types (u?int64_t, double)
You can see benchmark code and results here
Summarized result:
I am pretty new to this repo to tell me what to you think about this.