Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix const incorrectness on upb C gencode map types. #20384

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix const incorrectness on upb C gencode map types. #20384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions upb_generator/c/generator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,11 +218,11 @@ std::string CTypeConst(upb::FieldDefPtr field) {
}

std::string MapKeyCType(upb::FieldDefPtr map_field) {
return CType(map_field.message_type().map_key());
return CTypeConst(map_field.message_type().map_key());
}

std::string MapValueCType(upb::FieldDefPtr map_field) {
return CType(map_field.message_type().map_value());
return CTypeConst(map_field.message_type().map_value());
}

std::string MapKeyValueSize(upb_CType ctype, absl::string_view expr) {
Expand Down
Loading