Fix for issue 20371 related to deep depencies #20392
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to provide a fix for issue #20371 and improve the performance of csharp runtime when dealing with deep nested dependencies of .proto files.
The fix consists in caching the recursive calls for the search of extensions.
A test dataset has been created with deeply nested .proto files that showcases the performance penalty.
A set of benchmark metrics have been created to evaluate the performance impact before and after the fix.
Unfortunately due to not being able to unload all the existing objects inside the same testcase, it is only possible to run the test before and after enabling the caching mechanism. I am open to any other idea on how to improve this.
The test results before and after the fix are the following:
Before the proposed fix:
After the proposed fix: