Python: Option to validate duplicate fields during json deserialization #20418
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue
Proto:
Code:
Output:
Why is this a problem?
This is a pretty unexpected behavior. Even using json_name cannot fully prevent one from using duplicate fields in json.
What about implementations in other languages?
protobuf-go features a specific check for duplicate fields.
This PR is created similarly to C# PR
What does this PR do?
This PR improves checks for fields already used during JSON parsing. Back to the example, the result will be as follows:
Code:
Output: