Code

C# Proto2 feature : Finale#5936

Code

Merged

jtattermusch merged 34 commits intoprotocolbuffers:masterprotocolbuffers/protobuf:masterfrom ObsidianMinor:csharp/proto2-feature/finaleObsidianMinor/protobuf:csharp/proto2-feature/finaleCopy head branch name to clipboardSep 3, 2019

+32,176-403

Commits

Commits on Aug 23, 2019

• Remove internal constraint on descriptor proto

  ObsidianMinor

  committed
  5caa44e

  Copy full SHA for 5caa44e

• Remove proto2 check from generator

  ObsidianMinor

  committed
  4be0394

  Copy full SHA for 4be0394

• Reapply custom option accessors from previous PR along with CustomOptions accessor deprecations

  ObsidianMinor

  committed
  05712c6

  Copy full SHA for 05712c6

• Make extension container classes public and modify conformance to test proto2 messages

  ObsidianMinor

  committed
  0387204

  Copy full SHA for 0387204

• Uncomment option code in OneofDescriptor

  ObsidianMinor

  committed
  43619bb

  Copy full SHA for 43619bb

• Add checks to make sure values retrieved from CustomOptions match extension values

  ObsidianMinor

  committed
  6e7c43f

  Copy full SHA for 6e7c43f

• Add test protos to test project

  Show description for 8a57ec8
  ObsidianMinor

  committed
  8a57ec8

  Copy full SHA for 8a57ec8

• Fix incorrect code gen for string fields with default values

  ObsidianMinor

  committed
  a976158

  Copy full SHA for a976158

• Add tests for field presence and default values

  Show description for 8b7fb7d
  ObsidianMinor

  committed
  8b7fb7d

  Copy full SHA for 8b7fb7d

• Added FieldDescriptor.IsExtension and sealed ExtensionCollection

  ObsidianMinor

  committed
  8e917d1

  Copy full SHA for 8e917d1

• file descriptors and the syntax field are really weird with proto2

  ObsidianMinor

  committed
  5b2f2c5

  Copy full SHA for 5b2f2c5

• Fix issues from interactive rebase and regenerate code

  ObsidianMinor

  committed
  011427c

  Copy full SHA for 011427c

• Added group roundtrip tests and fixed any issues discovered

  ObsidianMinor

  committed
  cd65535

  Copy full SHA for cd65535

• Change input message to UnknownFieldSet tests to proto2 test message to test groups.

  ObsidianMinor

  committed
  134242b

  Copy full SHA for 134242b

• Add private "_Extensions" property to speed up IsInitialized checks

  ObsidianMinor

  committed
  ebf0bfa

  Copy full SHA for ebf0bfa

• Fix RepeatedExtensionValue.IsInitialized

  ObsidianMinor

  committed
  b78330b

  Copy full SHA for b78330b

• Remove unnecessary check in GetIsExtensionsInitialized

  ObsidianMinor

  committed
  8dc69ed

  Copy full SHA for 8dc69ed

• Remove dead HasValue code for ExtensionValue and add null-checks to ExtensionSet.Set

  ObsidianMinor

  committed
  f4cfd2d

  Copy full SHA for f4cfd2d

• Add ExtensionSet tests and add checks that non-message extension fields don't fail initialization checks

  ObsidianMinor

  committed
  0c80570

  Copy full SHA for 0c80570

• Add tests for extension accessor

  ObsidianMinor

  committed
  9163a6f

  Copy full SHA for 9163a6f

• Make extension reflection helper use GetOrRegisterExtension

  ObsidianMinor

  committed
  bf4f6c5

  Copy full SHA for bf4f6c5

• Reorganize some tests

  ObsidianMinor

  committed
  6b90ac1

  Copy full SHA for 6b90ac1

• Add missing files to Makefile.am

  ObsidianMinor

  committed
  2b9d0fd

  Copy full SHA for 2b9d0fd

• Regenerate testprotos.pb

  ObsidianMinor

  committed
  29d5186

  Copy full SHA for 29d5186

• Review changes

  Show description for 47f2017
  ObsidianMinor

  committed
  47f2017

  Copy full SHA for 47f2017

• Fix default extension values being unused in FieldCodec

  ObsidianMinor

  committed
  29141f4

  Copy full SHA for 29141f4

• Revert changes for FieldPresenceAccessor

  ObsidianMinor

  committed
  930db67

  Copy full SHA for 930db67

• Rename ExtensionRegistry.Add(IEnumerable<Extension>) overload to AddRange

  ObsidianMinor

  committed
  3237ad3

  Copy full SHA for 3237ad3

• Fix readability in FieldCodec.ForMessage/Group factories

  ObsidianMinor

  committed
  79cf8a8

  Copy full SHA for 79cf8a8

• Fix comment on IExtendableMessage.GetOrRegisterExtension

  ObsidianMinor

  committed
  c5fa0e0

  Copy full SHA for c5fa0e0

• GetOrRegisterExtension -> GetOrInitializeExtension

  Show description for 0436b8d
  ObsidianMinor

  committed
  0436b8d

  Copy full SHA for 0436b8d

• Add GeneratedMessageTest.Proto2.cs to EXTRA_DIST

  ObsidianMinor

  committed
  6da14fa

  Copy full SHA for 6da14fa

• Expose Extension field in FieldDescriptor

  ObsidianMinor

  committed
  bdc6cd1

  Copy full SHA for bdc6cd1

Commits on Aug 29, 2019

• Use proto2 and proto3 in unknown field tests

  ObsidianMinor

  committed
  4d5ae5b

  Copy full SHA for 4d5ae5b