3.10.x - Remove internal constraint on descriptor proto (C#) #6799
Conversation
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@ObsidianMinor I found one of your changes in master that I would like to see in the next release of the Google.Protobuf C# library. And, according to the contribution guidelines the process for patching a release with something from master is to cherry-pick. But, GoogleBot has identified that I'm not the author of the code in my PR, so it's currently blocked. Would you be able to follow the instructions above and leave the comment of |
|
We just released 3.10.1. Can this change wait until 3.11? |
|
What is the expected ETA for 3.11? |
|
We should have 3.11 release by Q4, but we haven't set any specific date yet. |
|
Regarding my ability to wait for 3.11, the best I can do is tell you why I need it - hopefully it will help. I'm working on a polyglot framework for serverless functions which currently has Java, JavaScript, Go and working on Rust support - http://github.com/cloudstateio/cloudstate. My contribution has been to work on the csharp implementation, and it is currently blocked by this issue. While I am happy building my own version of the Protobuf C# DLLs, it's not something that I can easily hand out to the community or to my peers to allow them to contribute. If it's possible to add this in easily to a 3.10.x patch, it would be appreciated. |
|
Hi Jonathan! Thanks for explaining the background. While we definitely don't want you to be blocked, doing a release comes with a few overheads, e.g. updating the versions, updating changes.txt, building protoc, uploading protoc artifacts to Maven, building all the binaries and creating a new release in GitHub with the binaries. That's why we tend to do avoid doing minor releases unless it's a bugfix. I understand that depending on a locally built package is never an ideal solution, but will it be reasonable for you to do that until 3.11 comes out? I'm not a C# expert but if you need help building the nuget packages, I will be able do that pretty easily using our release script. Meanwhile I'll discuss with the team to come up with a more specific timeline for 3.11. |
|
@nagytech we're doing a 3.11 release sometime next week, thanks for the patience! |
|
Protobuf 3.11.0-RC1 has been published to nuget. |
Cherry picking 69cb61c from master to help resolve some issues that I'm currently facing. Also found that someone else was facing the same issue #5441, and noted that it may be blocking of #658.