Build extensions for Ruby 2.7

[qnighy]

I've made two groundworks for building protobuf extensions for Ruby 2.7:

• Reporting ruby issue at https://bugs.ruby-lang.org/issues/16384, which was fixed in ruby/ruby@40026a4
• Reporting rake-compiler issue at Fix missing Makefile.in in Ruby 2.7 rake-compiler/rake-compiler#161, which was fixed in rake-compiler/rake-compiler@6822686

Now that 2.7.0-rc2 has been released, can we start building extensions for Ruby 2.7?

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[casperisfine]

@haberman sorry for the ping, but any change for this to be merged ?

[haberman]

No worries about the ping, please take a look at the test failures. Feel free to ping me again.

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[qnighy]

Ah OK, the CI doesn't run automatically.

[qnighy]

From https://source.cloud.google.com/results/invocations/ac6df955-314c-45f7-8e2e-a9a2cbfdedbc/targets/protobuf%2Fgithub%2Fmaster%2Fubuntu%2Fruby_release%2Fpresubmit/log ...

/usr/local/rvm/rubies/ruby-2.5.3/lib/ruby/site_ruby/2.5.0/rubygems.rb:289:in `find_spec_for_exe': can't find gem bundler (>= 0.a) with executable bundle (Gem::GemNotFoundException)
	from /usr/local/rvm/rubies/ruby-2.5.3/lib/ruby/site_ruby/2.5.0/rubygems.rb:308:in `activate_bin_path'
	from /usr/local/rvm/gems/ruby-2.5.3/bin/bundle:23:in `<main>'
	from /usr/local/rvm/gems/ruby-2.5.3/bin/ruby_executable_hooks:24:in `eval'
	from /usr/local/rvm/gems/ruby-2.5.3/bin/ruby_executable_hooks:24:in `<main>'
rake aborted!
Command failed with status (1): [docker run -v /tmpfs/src/github/protobuf/ruby:/tmpfs/src/github/protobuf/ruby -e UID\=1000 -e GID\=1000 -e USER\=kbuilder -e GROUP\=kbuilder -e ftp_proxy\= -e http_proxy\= -e https_proxy\= -e RCD_HOST_RUBY_PLATFORM\=x86_64-linux -e RCD_HOST_RUBY_VERSION\=2.4.1 -e RCD_IMAGE\=protobuftesting/ruby_rake_compiler_52bbc96c6d72ba1b25e99e19bdcfeb240438566c -w /tmpfs/src/github/protobuf/ruby --rm -i protobuftesting/ruby_rake_compiler_52bbc96c6d72ba1b25e99e19bdcfeb240438566c runas sigfw bash -c bundle\ \&\&\ IN_DOCKER\=true\ rake\ cross\ native\ gem\ RUBY_CC_VERSION\=2.7.0:2.6.0:2.5.0:2.4.0:2.3.0]

I guess there's a mismatch in bundler versions? one is from kokoro/linux/dockerfile/release/ruby_rake_compiler/Dockerfile and the other is from kokoro/release/ruby/linux/ruby/ruby_build_environment.sh.

[casperisfine]

I guess there's a mismatch in bundler versions?

Yeah that's a classic error with Ruby 2.7

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

[haberman]

@qnighy Looks like we're still getting an error. :(

/Users/kbuilder/.rvm/rubies/ruby-2.7.0/lib/ruby/2.7.0/x86_64-darwin18/rbconfig.rb:13:in `<module:RbConfig>': ruby lib version (2.7.0) doesn't match executable version (2.6.0) (RuntimeError)
	from /Users/kbuilder/.rvm/rubies/ruby-2.7.0/lib/ruby/2.7.0/x86_64-darwin18/rbconfig.rb:11:in `<top (required)>'
	from /Users/kbuilder/.rvm/rubies/ruby-2.7.0/lib/ruby/2.7.0/fileutils.rb:4:in `require'
	from /Users/kbuilder/.rvm/rubies/ruby-2.7.0/lib/ruby/2.7.0/fileutils.rb:4:in `<top (required)>'
	from /Users/kbuilder/.rake-compiler/sources/ruby-2.6.0/tool/transform_mjit_header.rb:5:in `require'
	from /Users/kbuilder/.rake-compiler/sources/ruby-2.6.0/tool/transform_mjit_header.rb:5:in `<main>'
make: *** [.ext/include/x86_64-darwin11/rb_mjit_min_header-2.6.0.h] Error 1

[qnighy]

grpc/grpc@4c66747 do we perhaps need to get rid of grpctesting/rake-compiler-dock_53c22085d091183c528303791e7771359f699bcf?

[qnighy]

@haberman I'd like to see what happens when I remove the custom RCD image. Could you kick the CI again?

[qnighy]

Okay, this change must be important: grpc/grpc@4c66747#diff-52c976fc38ed2b4e3b1192f8a8e24cffL131-R150

@haberman one more kick, please? Thanks in advance!

[haberman]

Looks like we're still getting an error:

/Users/kbuilder/.rvm/rubies/ruby-2.7.0/bin/ruby --disable=gems -I/Users/kbuilder/.rake-compiler/builds/x86_64-darwin11/ruby-2.6.0 -rx86_64-darwin11-fake  /Users/kbuilder/.rake-compiler/sources/ruby-2.6.0/tool/transform_mjit_header.rb "clang " rb_mjit_header.h .ext/include/x86_64-darwin11/rb_mjit_min_header-2.6.0.h
/Users/kbuilder/.rvm/rubies/ruby-2.7.0/lib/ruby/2.7.0/x86_64-darwin18/rbconfig.rb:13:in `<module:RbConfig>': ruby lib version (2.7.0) doesn't match executable version (2.6.0) (RuntimeError)
	from /Users/kbuilder/.rvm/rubies/ruby-2.7.0/lib/ruby/2.7.0/x86_64-darwin18/rbconfig.rb:11:in `<top (required)>'
	from /Users/kbuilder/.rvm/rubies/ruby-2.7.0/lib/ruby/2.7.0/fileutils.rb:4:in `require'
	from /Users/kbuilder/.rvm/rubies/ruby-2.7.0/lib/ruby/2.7.0/fileutils.rb:4:in `<top (required)>'
	from /Users/kbuilder/.rake-compiler/sources/ruby-2.6.0/tool/transform_mjit_header.rb:5:in `require'
	from /Users/kbuilder/.rake-compiler/sources/ruby-2.6.0/tool/transform_mjit_header.rb:5:in `<main>'
make: *** [.ext/include/x86_64-darwin11/rb_mjit_min_header-2.6.0.h] Error 1

Do you think it's worth trying ruby-install and chruby instead of rvm?

• https://github.com/postmodern/ruby-install
• https://github.com/postmodern/chruby instead

In my experience, ruby-install and chruby (along with bundle exec) have been really solid ways of switching between Ruby versions.

[qnighy]

Do you think it's worth trying ruby-install and chruby instead of rvm?

I'll instead follow the grpc/grpc's approach: grpc/grpc@09bc1ee

[qnighy]

I guess when I update dockerfiles in kokoro/linux/dockerfile/test, someone with a certain privilege has to invoke kokoro/linux/dockerfile/push_testing_images.sh manually?

Then, in this PR, I'd like to focus on building extensions for Ruby 2.7. I'll prepare another PR for testing protobuf in Ruby 2.7.

[qnighy]

@haberman can it be merged? I think the remaining CI failures are unrelated to this PR.

[qnighy]

Thanks a lot! I'm really glad to see this merged.