Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add application note for explicit presence tracking. #7390

Merged
merged 3 commits into from
Apr 23, 2020
Merged

Add application note for explicit presence tracking. #7390

merged 3 commits into from
Apr 23, 2020

Conversation

dlj-NaN
Copy link
Contributor

@dlj-NaN dlj-NaN commented Apr 16, 2020

Singular, non-message typed fields in proto3 experimentally support explicit presence tracking (see docs/field_presence.md for details).

@dlj-NaN
Add an application note for field presence.
001f6f8 
This includes instructions for enabling explicit presence tracking in proto3, and also explains implicit presence. The language examples were written by inspection, and not individually tested.
@dlj-NaN dlj-NaN requested a review from haberman April 16, 2020 09:12
haberman
haberman requested changes Apr 20, 2020
View reviewed changes
Copy link
Member

@haberman haberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't been able to get through all of this yet, but a few preliminary comments.

@dlj-NaN dlj-NaN mentioned this pull request Apr 23, 2020
Merged
haberman
haberman requested changes Apr 23, 2020
View reviewed changes
Copy link
Member

@haberman haberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! I went through the rest of the doc and found a few more things.

@dlj-NaN
Updated wording:
d87c105 
 - noted experimental status in release 3.12
 - clarified JSON null and ordering concerns
 - "implicit presence" -> "no presence"
 - clarified message presence in proto3
 - fixed round-trip example (client definitions were switched)
@dlj-NaN dlj-NaN merged commit e48c929 into protocolbuffers:master Apr 23, 2020
@dlj-NaN dlj-NaN deleted the appnote branch April 23, 2020 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haberman haberman haberman approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlj-NaN @haberman @googlebot