Add a setuptools extension for generating Python protobufs #7783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ode. This extension allows Python code to be generated from setup.py files, so they are created as part of a normal Python build. The extension uses an already-existing protoc binary, which can be explicitly specified if needed.
- Added classifiers, including Python versions to match the protobuf package. - Excluded the distutils plugin from the larger protobuf package.
bobhancock
reviewed
Aug 10, 2020
haberman
approved these changes
Aug 10, 2020
…_py_proto(bufs?).
bobhancock
reviewed
Aug 11, 2020
| name='example_project', | ||
|
|
||
| # Require this package, but only for setup (not installation): | ||
| setup_requires=['protobuf_distutils'], |
There was a problem hiding this comment.
The package installs as protobuf-disutils, with a hyphen not an underbar.
After running build and install:
python -m pip freeze|grep protobuf
protobuf-distutils==1.0
bobhancock
reviewed
Aug 11, 2020
…rts. This must be a prefix of `source_dir`.
vesavlad
pushed a commit
to vesavlad/protobuf
that referenced
this pull request
Sep 22, 2020
…uffers#7783) This extension allows Python code to be generated from setup.py files, so they are created as part of a normal Python build. The extension uses an already-existing protoc binary, which can be explicitly specified if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This setuptools extension generates Python protobuf code from .proto files, so they
can be created as part of a normal Python build. The extension uses an installed
protoc binary, which can be explicitly specified if needed.