Added support for "==" to the PHP C extension #7883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TeBoring
reviewed
Sep 11, 2020
| $m2->getMapInt32Message()[1]->setA(1234); | ||
| $this->assertTrue($m1 != $m2); | ||
|
|
||
| # TODO: what about unknown fields? |
There was a problem hiding this comment.
Question, is equal only recommend for test? If so, I think we don't need to worry about it.
Otherwise, I think not comparing equal ensures backward compatibility.
TeBoring
approved these changes
Sep 11, 2020
|
I think I'll submit this for now and address the unknown field issue in a follow-up. |
vesavlad
pushed a commit
to vesavlad/protobuf
that referenced
this pull request
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this CL, the
==operator in PHP worked as expected for the pure-PHP library, but not for the C extension.This PR fixes the C extension to have proper
==semantics. It also adds tests that pass for both pure-PHP and the C extension.Fixes: #7650