Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework compiler/linker flags #10

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Rework compiler/linker flags #10

merged 1 commit into from
Jun 21, 2021

Conversation

wavexx
Copy link
Collaborator

@wavexx wavexx commented Feb 7, 2021

  • Remove unnecessary warning flags during linking stage
  • Remove -fuse-linker-plugin, implied by -flto at link time
  • Remove -fpermissive to avoid future warning creep (depends on ⚡️New SD menu Prusa-Firmware#2405)
  • Add -fno-rtti for c++ (no savings, just to avoid future usage of rtti)

@wavexx
Rework compiler/linker flags
6576781 
- Remove unnecessary warning flags during linking stage
- Remove -fuse-linker-plugin, implied by -flto at link time
- Remove -fpermissive to avoid future warning creep (depends on prusa3d/Prusa-Firmware#2405)
- Add -fno-rtti for c++ (no savings, just to avoid future usage of rtti)
@leptun
Copy link
Collaborator

leptun commented Feb 7, 2021

I totally approve the removal of -fpermissive, but only after the new SD menu is merged as that generates a const pointer violation.

@DRracer DRracer merged commit 37f2bee into prusa3d:master Jun 21, 2021
3d-gussner added a commit to 3d-gussner/PF-build-env-1 that referenced this pull request Jul 13, 2021
@3d-gussner
Update to Arduino_boards v1.0.4 see
c8eb1ed 
prusa3d/Arduino_Boards#8
prusa3d/Arduino_Boards#10
prusa3d/Arduino_Boards#11
prusa3d/Arduino_Boards#12
@3d-gussner 3d-gussner mentioned this pull request Jul 14, 2021
Merged
@wavexx wavexx deleted the rework_compiler_flags branch September 11, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DRracer DRracer DRracer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wavexx @leptun @DRracer