PFW-1052: "Unknown z" improvements #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 25, 2019
wavexx
force-pushed
the
unknown_z_improvements
branch
3 times, most recently
from
6c0b55a to
cfe0347
Compare
|
@mkbel Noticed dad2065 now conflicts with this. Since lcd_mmu_load_to_nozzle can probably be called without Z being homed yet, I assume the above still applies. It doesn't raise while extruding since SG can be on, but I could definitely also include this option by combining both moves if Z is known, and doing them separately if not. |
wavexx
force-pushed
the
unknown_z_improvements
branch
from
cfe0347 to
d055ae1
Compare
|
I updated the PR to combine raising and slow extrusion, as "rise_z" did. |
wavexx
force-pushed
the
unknown_z_improvements
branch
from
d055ae1 to
09ec930
Compare
Closed
leptun
reviewed
Jul 12, 2019
| @@ -3166,10 +3200,7 @@ void gcode_M701() | |||
| plan_buffer_line(current_position[X_AXIS], current_position[Y_AXIS], current_position[Z_AXIS], current_position[E_AXIS], 400 / 60, active_extruder); //fast sequence | |||
| st_synchronize(); | |||
|
|
|||
| marlin_rise_z(); | |||
| current_position[E_AXIS] += 30; | |||
There was a problem hiding this comment.
Why didn't you keep this line? With these changes my filament only loads to the nozzle and doesn't extrude any filament. I have to click NO and only then does it start extruding
|
On Fri, Jul 12 2019, leptun wrote:
- marlin_rise_z();
- current_position[E_AXIS] += 30;
Good thing you noticed. Probably shuffled during one of the rebases with
the following commit.
|
wavexx
force-pushed
the
unknown_z_improvements
branch
from
09ec930 to
1ee8d58
Compare
|
Updated |
wavexx
force-pushed
the
unknown_z_improvements
branch
from
1ee8d58 to
3c220ac
Compare
- Introduce raise_z_above to move Z carefully when the current position
is potentially unknown, using stallguard
- Use raise_z_above for:
* filament loading/unloading clearance
* extruder spacing when preheating (to avoid buildplate marks on PEI)
* before homing to avoid damaging the build plate and to avoid
repeated Z moves as well
Since raise_z_above is conditional, it will only raise when needed.
Calling raise_z_above when the extruder position is unknown and already
at maximum travel is safe and will prevent further vertical moves.
wavexx
force-pushed
the
unknown_z_improvements
branch
from
3c220ac to
e25befa
Compare
DRracer
approved these changes
Nov 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1748
I introduce a new function, raise_z_above to move Z carefully when the current position is potentially unknown, making it useful for several lcd functions which can be issued just after starting the printer.
raise_z_above uses stallguard when the Z position is unknown and a regular move otherwise.
The following conditions will now use raise_z_above:
during filament loading/unloading, for blob clearance.
extruder spacing when preheating. This is done to avoid buildplate marks on the PEI sheet, which is something I have, as I often preheat from the menu and sometimes come back late.
before homing to avoid scratching the build plate. This was already done, but incorrectly.
In the original homing sequence, G28 will raise Z, home XY, then raise again unconditionally. If the printer was already at max height, a G28 will crash twice against the Z tops. The same was true during filament unloading if the printer was reset and issued an unload from the LCD.
raise_z_above is a no-op if the position is already above the target, which avoids several useless moves also when homing the axes independently.