PFW-1055: M350 for all axis - MK3 #2057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've applied this to a local build and it does indeed work as expected. |
|
Testing: Try setting a different resolution for X or Y (eg 32) and see if everything still works. Also test saving the values to eeprom |
DRracer
reviewed
Nov 8, 2019
Firmware/Marlin_main.cpp
Outdated
| uint16_t res = tmc2130_get_res(i); | ||
| tmc2130_set_res(i, res_new); | ||
| cs.axis_ustep_resolution[i] = res_new; | ||
| uint16_t fac; |
There was a problem hiding this comment.
even though extracting this var away from the if-else subtree may look like correct programming paradigm, however it may also prevent optimization
DRracer
approved these changes
Nov 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2024