-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PFW-1061: #2093 - Relocate sheet menu, show sheet on info screen #2146
Conversation
-Sheet is shown instead of percentage done either if idle, or during print preheat. -Relocated sheet menu to below SD menu for additional visibility to current sheet.
@vintagepc Good ideas, thanks for your PR. For now the sheets menu will be like we have it in #2145, but I really like your idea about the status screen showing sheet name instead of percentage in idle. I'll talk about it with our content guys. |
That's fair, looks like we essentially did the same thing for the menu move (though I didn't hide mine if there's only a single sheet in use) |
Fixed #2089, merged Mk3 |
@vintagepc I'm marking this as 3.9.x but please note we are still to gain some significant user response about the sheets, so this PR may require some more changes |
Understood, I'm hoping to keep it maintained as new features are added to the firmware. |
I merged 3.8.1-RC1 into my local branch which has this applied and it still functions as expected 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
besides the cursor '^' change we are ready to merge this, please finish the PR as requested, thank you
Per PR fix request
I guess I can cross "Earn 'contributor' badge for Prusa Github" off my bucket list now 😄 |
Implemented #2093
-Sheet is shown instead of percentage done either if idle, or during
print preheat. (Both consume exactly 7 characters)
-Relocated sheet menu to below SD menu for additional visibility to
current sheet.