Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PFW-1061: #2093 - Relocate sheet menu, show sheet on info screen #2146

Merged
merged 5 commits into from
Nov 15, 2019

Conversation

vintagepc
Copy link
Contributor

@vintagepc vintagepc commented Aug 29, 2019

Implemented #2093
-Sheet is shown instead of percentage done either if idle, or during
print preheat. (Both consume exactly 7 characters)
-Relocated sheet menu to below SD menu for additional visibility to
current sheet.

-Sheet is shown instead of percentage done either if idle, or during
print preheat.
-Relocated sheet menu to below SD menu for additional visibility to
current sheet.
@vintagepc vintagepc mentioned this pull request Aug 29, 2019
@DRracer
Copy link
Collaborator

DRracer commented Aug 30, 2019

@vintagepc Good ideas, thanks for your PR. For now the sheets menu will be like we have it in #2145, but I really like your idea about the status screen showing sheet name instead of percentage in idle. I'll talk about it with our content guys.

@vintagepc
Copy link
Contributor Author

That's fair, looks like we essentially did the same thing for the menu move (though I didn't hide mine if there's only a single sheet in use)

@vintagepc
Copy link
Contributor Author

I'll merge to synchronize with #2145's changes and I realized I can also toss in a fix for #2089 which should be an easy fix.

@vintagepc
Copy link
Contributor Author

Fixed #2089, merged Mk3

@DRracer
Copy link
Collaborator

DRracer commented Sep 10, 2019

@vintagepc I'm marking this as 3.9.x but please note we are still to gain some significant user response about the sheets, so this PR may require some more changes

@vintagepc
Copy link
Contributor Author

Understood, I'm hoping to keep it maintained as new features are added to the firmware.

@vintagepc
Copy link
Contributor Author

I merged 3.8.1-RC1 into my local branch which has this applied and it still functions as expected 👍

Copy link
Collaborator

@DRracer DRracer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides the cursor '^' change we are ready to merge this, please finish the PR as requested, thank you

@DRracer DRracer changed the title #2093 - Relocate sheet menu, show sheet on info screen PFW-1061: #2093 - Relocate sheet menu, show sheet on info screen Nov 15, 2019
@DRracer DRracer merged commit 3a41405 into prusa3d:MK3 Nov 15, 2019
@vintagepc
Copy link
Contributor Author

I guess I can cross "Earn 'contributor' badge for Prusa Github" off my bucket list now 😄

@vintagepc vintagepc deleted the MK3-2093-sheet-display branch February 29, 2020 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants