Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add M256 [ B | D | S | T ] #4851

Merged
merged 2 commits into from
Feb 28, 2025
Merged

Add M256 [ B | D | S | T ] #4851

merged 2 commits into from
Feb 28, 2025

Conversation

3d-gussner
Copy link
Collaborator

@3d-gussner 3d-gussner commented Feb 26, 2025 •
edited
Loading

Solves feature request #3470

  • Removed hard coded values and added
    • LCD_BACKLIGHT_LEVEL_HIGH 130
    • LCD_BACKLIGHT_LEVEL_LOW 50
    • LCD_BACKLIGHT_FORCE_ON 30
    • LCD_BACKLIGHT_TIMEOUT 15

M256 [ B | D | S | T ]

Parameters
- `B` - Normal Brightness value (0 - 255), default 130
- `D` - Dimmed Brightness value (0 - 255), default 50
- `S` - Brightness mode, default Auto
  - `0` - Dim
  - `1` - Bright
  - `2` - Auto
- `T` - Brightness timeout  (15 - 900), default 15 seconds

Post release tasks

  • Update Gcode doxygen
  • Update RepRap Gcode Wiki

@3d-gussner
Add M256
34450f5 
- Removed hardcoded values and added
  - LCD_BACKLIGHT_LEVEL_HIGH 130
  - LCD_BACKLIGHT_LEVEL_LOW 50
  - LCD_BACKLIGHT_FORCE_ON 30
  - LCD_BACKLIGHT_TIMEOUT 15
@3d-gussner 3d-gussner requested a review from leptun February 26, 2025 12:39
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 26, 2025 •
edited
Loading

All values in bytes. Δ Delta to base

Target ΔFlash ΔSRAM Used Flash Used SRAM Free Flash Free SRAM
MK3S_MULTILANG 442 0 248134 5654 5818 2538
MK3_MULTILANG 450 0 247512 5663 6440 2529

@3d-gussner 3d-gussner added the Post release tasks open Tasks after release label Feb 27, 2025
@3d-gussner 3d-gussner mentioned this pull request Feb 27, 2025
Open
gudnimg
gudnimg reviewed Feb 27, 2025
View reviewed changes
gudnimg
gudnimg reviewed Feb 27, 2025
View reviewed changes
@3d-gussner 3d-gussner merged commit 6c6476c into prusa3d:MK3 Feb 28, 2025
4 checks passed
@3d-gussner 3d-gussner deleted the MK3_LCD_Brightness branch February 28, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gudnimg gudnimg gudnimg approved these changes

@leptun leptun Awaiting requested review from leptun

@sarusani sarusani Awaiting requested review from sarusani

Assignees
No one assigned
Labels
Post release tasks open Tasks after release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@3d-gussner @gudnimg