Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a dedicated PR to fix #6900.
As I said in the issue, this looks like a bug of
requests_toolbelt
but turns out that it belongs to therequests
itself.Basically, what
HostHeaderSSLAdapter
does is quite simple:As you can see, it simply set
assert_hostname
to the custom SNI for theurllib3.poolmanager.connection_pool_kw
.When the proxy is set, the function
adapters.py!proxy_manager_for()
forgets to copy theconnection_pool_kwargs
property from the currentpoolmanager
, which will cause the SSL verification exception when the user is doing the request with the custom SNI and self-signed certificate.