Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add version checking for torch._dynamo import in __init__ #1881

Merged
merged 1 commit into from
May 3, 2023
Merged

fix: Add version checking for torch._dynamo import in __init__ #1881

merged 1 commit into from
May 3, 2023

Conversation

gs-olive
Copy link
Collaborator

@gs-olive gs-olive commented May 3, 2023

Description

  • Ensure torch._dynamo can be imported by validating Torch version
  • Intended to fix legacy CI run

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive gs-olive added the WIP Work is in progress, pull request should not be merged yet label May 3, 2023
@gs-olive gs-olive self-assigned this May 3, 2023
@github-actions github-actions bot added the component: api [Python] Issues re: Python API label May 3, 2023
@github-actions github-actions bot requested a review from narendasan May 3, 2023 03:06
@gs-olive gs-olive changed the title fix: Add version checking for Torch Dynamo import on new dynamo path fix: Add version checking for torch._dynamo import in __init__ May 3, 2023
@gs-olive
fix: Add version checking for Torch Dynamo import
fce74b6 
- Ensure `torch._dynamo` can be imported by validating Torch version
- Intended to fix legacy CI run
@gs-olive gs-olive force-pushed the legacy_dynamo_fix branch from 91d1497 to fce74b6 Compare May 3, 2023 04:13
@gs-olive gs-olive removed the WIP Work is in progress, pull request should not be merged yet label May 3, 2023
narendasan
narendasan approved these changes May 3, 2023
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gs-olive gs-olive merged commit 55a17b4 into pytorch:main May 3, 2023
gs-olive added a commit that referenced this pull request May 3, 2023
@gs-olive
fix: Add version checking for torch._dynamo import in __init__ (#…
cde4803 
…1881)
gs-olive added a commit that referenced this pull request May 4, 2023
@gs-olive
fix: Add version checking for torch._dynamo import in __init__ (#…
d3d2520 
…1881)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan approved these changes

Assignees

@gs-olive gs-olive

Labels
cla signed component: api [Python] Issues re: Python API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gs-olive @narendasan @facebook-github-bot