Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip tests with internal/external discrepancy #2759

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TroyGarden
Copy link
Contributor

Summary:

context

  • in torchrec github (OSS env) a few tests are failing
  • however, these tests pass internally due to different set up
  • torch.export uses training ir externally but inference ir internally
  • dlrm transformer tests use random.seed(0) to generate initial weights and the numeric values might be different internally and externally

Differential Revision: D69996988

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 21, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69996988

TroyGarden added a commit to TroyGarden/torchrec that referenced this pull request Feb 21, 2025
Summary:

# context
* in torchrec github (OSS env) a few tests are [failing](https://github.com/pytorch/torchrec/actions/runs/13449271251/job/37580767712)
* however, these tests pass internally due to different set up
* torch.export uses training ir externally but inference ir internally
* dlrm transformer tests use random.seed(0) to generate initial weights and the numeric values might be different internally and externally

Differential Revision: D69996988
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69996988

TroyGarden added a commit to TroyGarden/torchrec that referenced this pull request Feb 21, 2025
Summary:

# context
* in torchrec github (OSS env) a few tests are [failing](https://github.com/pytorch/torchrec/actions/runs/13449271251/job/37580767712)
* however, these tests pass internally due to different set up
* torch.export uses training ir externally but inference ir internally
* dlrm transformer tests use random.seed(0) to generate initial weights and the numeric values might be different internally and externally

Differential Revision: D69996988
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69996988

Summary:

# context
* in torchrec github (OSS env) a few tests are [failing](https://github.com/pytorch/torchrec/actions/runs/13449271251/job/37580767712)
* however, these tests pass internally due to different set up
* torch.export uses training ir externally but inference ir internally
* dlrm transformer tests use random.seed(0) to generate initial weights and the numeric values might be different internally and externally

Differential Revision: D69996988
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69996988

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants