Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2083 Fix subexpression calculation #2084

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

IvanHristov98
Copy link
Contributor

Fix subexpression calculation

Description

Fixes how subexpressions are calculated. An example formula that is incorrectly calculated is =IF(2<0, 1, (4)). More examples are provided in the related issue.

Related Issue

#2083

Motivation and Context

It fixes the calculation when there are subexpressions.

How Has This Been Tested

With unit tests. I incidentally found this issue while working with the library.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@xuri xuri added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 7, 2025
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.20%. Comparing base (4324622) to head (90fbcdc).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2084      +/-   ##
==========================================
- Coverage   99.20%   99.20%   -0.01%     
==========================================
  Files          32       32              
  Lines       30075    30070       -5     
==========================================
- Hits        29837    29832       -5     
  Misses        158      158              
  Partials       80       80              
Flag Coverage Δ
unittests 99.20% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xuri xuri linked an issue Feb 7, 2025 that may be closed by this pull request
2 tasks
Copy link
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your great work.

@xuri xuri merged commit 718417e into qax-os:master Feb 8, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Status: Bugfix
Development

Successfully merging this pull request may close these issues.

Subexpressions aren't correctly calculated
2 participants