Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix go mod version parse #391

Closed
wants to merge 3 commits into from
Closed

Fix go mod version parse #391

wants to merge 3 commits into from

Conversation

IfanTsai
Copy link
Contributor

No description provided.

IfanTsai and others added 3 commits September 27, 2023 14:38
@IfanTsai
fix duplicate import of global var path in symlink file
bccdb98 
eg. main.go -> cmd/myproject/run.go
When run `goc build .`, redeclared error will be reported.
In main.go, the global var path is duplicated imported as follows:
`package main; import . "myproject/src/gocbuild235e80d276dc"; import . "myproject/src/gocbuild234e80d276dc"`
@IfanTsai
Merge branch 'qiniu:master' into master
890f131
@IfanTsai
fix go version parse error in go.mod
34d40a2
@qiniu-prow qiniu-prow
Copy link

qiniu-prow bot commented Nov 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: IfanTsai
Once this PR has been reviewed and has the lgtm label, please assign memoryliu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qiniu-prow qiniu-prow bot added the size/XS label Nov 15, 2024
@qiniu-x qiniu-x
Copy link

qiniu-x bot commented Nov 15, 2024

[Git-flow] Hi @IfanTsai, There are some suggestions for your information:

Rebase suggestions

  • Following commits seems generated via git merge

    Merge branch 'qiniu:master' into master

Which seems insignificant, recommend to use git rebase command to reorganize your PR.

For other git-flow instructions, recommend refer to these examples.

If you have any questions about this comment, feel free to raise an issue here:

@IfanTsai IfanTsai closed this by deleting the head repository Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@IfanTsai