You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not 100% sure about this pull request because I couldn't replicate the issue with pico-sdk, but since I had this issue with downstream and these fixes worked (and for consistency), I figured it was worth pushing the changes upstream anyway.
I'm not 100% sure about this pull request because I couldn't replicate the issue with pico-sdk
That's probably because this cmake file is in external/ and there's nothing in pico-sdk itself which actually uses it! It only exists so that it can be copied into external projects (like debugprobe) that wish to make use of pico-sdk 🙂
I'm not 100% sure about this pull request because I couldn't replicate the issue with pico-sdk
That's probably because this cmake file is in external/ and there's nothing in pico-sdk itself which actually uses it! It only exists so that it can be copied into external projects (like debugprobe) that wish to make use of pico-sdk 🙂
Ah, right. So it's worth keeping the changes then, since it'll be pulled downstream by other projects.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1043 (additional fixes, this time for
external/pico_sdk_import.cmake).Some pathname spacing (and special characters) still causes issues.
Related to this pull request from raspberrypi/debugprobe.
I'm not 100% sure about this pull request because I couldn't replicate the issue with pico-sdk, but since I had this issue with downstream and these fixes worked (and for consistency), I figured it was worth pushing the changes upstream anyway.