-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Log] Ignore callstacktrace test for windows #11413
[Log] Ignore callstacktrace test for windows #11413
Conversation
Why do we do this? Is this not working on Windows? |
Max depth of GetStackStrace is 32, but It will dump more than 32 frames before test case so we can't catch the all stack frames within 32 depth size. |
You may find the detail in https://github.com/ray-project/ray/pull/11410/checks?check_run_id=1257791585 |
These are stacktrace on windows. I have no idea about that. It looks like other thread stack not main thread where gtest test case run in.
|
@ashione Are you suggesting that |
+1 for @kfstorm's qusetion. |
Stacktrace seems unsupported in glog of ray on windows. I find the glog patch google/glog#168 porting a feature to windows about OS stacktrace. @rkooo567 @kfstorm it's workaround by merging this PR and think about how to get glog's patch in later. |
Why are these changes needed?
Related issue number
Checks
scripts/format.sh
to lint the changes in this PR.