Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cron): add support for day-of-week special characters #150

Merged
merged 2 commits into from
Feb 1, 2025

Conversation

reugn
Copy link
Owner

@reugn reugn commented Feb 1, 2025

Implement support for L (last day) and # (nth day) special characters in the cron day-of-week field.

@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 92.68293% with 3 lines in your changes missing coverage. Please review.

Project coverage is 94.83%. Comparing base (9dff931) to head (5e9fff0).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
quartz/cron.go 92.10% 2 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
+ Coverage   94.44%   94.83%   +0.39%     
==========================================
  Files          19       19              
  Lines        1152     1182      +30     
==========================================
+ Hits         1088     1121      +33     
+ Misses         47       45       -2     
+ Partials       17       16       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reugn reugn merged commit f817e56 into master Feb 1, 2025
5 checks passed
@reugn reugn deleted the cron-day-of-week-characters branch February 1, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants