eci2ecef: thread safety, add THREADLOCAL #587
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a THREADLOCAL definition that maps to _Thread_local for C11, __thread for gcc, and __declspec(__thread) for MSC. Use this to make the eci2ecef() cache thread safe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a THREADLOCAL definition that maps to _Thread_local for C11, __thread for gcc, and __declspec(__thread) for MSC.
Use this to make the eci2ecef() cache thread safe.
Testing on linux. If people could test this on other platforms, and if there is a workable thread local declaration, then this could be useful in a few other places. Worst case the definition could be empty for platforms without thread local storage declarations and then these uses would remain not thread safe for now on these platforms. The MSC declaration is based on https://learn.microsoft.com/en-us/cpp/cpp/thread?view=msvc-170 For C11 _Thread_local appears to be usable, but RTKLIB currently targets C99 so this also maps to GCC amd MSC extensions.