Rollback database when backing sql source is removed #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -87,6 +87,7 @@ func (b byId) Less(i, j int) bool { return b[i].Less(b[j]) } | |||
| type MigrationRecord struct { | |||
| Id string `db:"id"` | |||
| AppliedAt time.Time `db:"applied_at"` | |||
| DownSql string `db:"down_sql"` | |||
There was a problem hiding this comment.
This will be a problem, anyone who is currently using sql-migrate won't have this column in their migrations table.
We've come at the sad point that we'll need to migrate the migrations table, but we have no way of doing so.
There was a problem hiding this comment.
Ugh, that's a good point. I'll try to add something that detects an older database and migrate it but that feels "off", especially since package is meant to migrate databases!
There was a problem hiding this comment.
Hmmm. What if we store the DownSql in a separate new table? Does that let us avoid compatibility issues?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When redeploying an older version of the app, the database is left in it's newest state, even if the older application expects an older version of the database.
To rollback when an older version of the app is deployed, we must: