feat: Trim backticks from MR comments (for Gitlab) #5244
Merged
+28
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unibozu
requested review from
GenPage,
nitrocode and
X-Guardian
and removed request for
a team
dosubot
bot
added
feature
Unibozu
changed the title
Unibozu
changed the title
Signed-off-by: Clement Debiaune <[email protected]>
Unibozu
force-pushed
the
feat-comment-trim
branch
from
7a936d9 to
2e9e270
Compare
|
This doesn't change the appearance of the comment, right? I think we still want the suggested command to appear as a "command" in backticks, is that formatting handled elsewhere? |
jamengual
added
waiting-on-response
Indeed. It only changes the parsing of the commands to ignore backticks. It's a minor change for convenience with people using Gitlab, it will be invisible to everyone else. |
|
Oh I see, yeah makes sense to me! |
lukemassa
approved these changes
Jan 20, 2025
|
thanks, @Unibozu, for the contribution |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Small change to trim backticks (
`) from MR comments to help with copy pasting atlantis commands from Gitlab. This is in addition to trimming whitespace.why
Gitlab adds backticks when copy pasting code, which currently fails with atlantis and requires having to remove them before submitting the comment.
For example, copying this pre-populated code
Becomes
tests
Added a unit test