Add implementation and test for discover_path #883
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi y'all,
We're looking to use this library to build the git integration in our code editor (zed.dev). In order to do so, we wanted to cache the Repository::open_ext() call based on the repository path. But git2-rs's implementation of
Repository::discover()
automatically opens the repository for us, making it impossible to cache :(I've added a
Repository::discover_path()
function that more closely matches the libgit2git_repository_discover()
call. I had to add an extra allocation to convert the git buffer into aPathBuf
and would appreciate feedback on if there's a way to avoid the allocation.I also added 2 tests, one for a successful discovery and one for an unsuccessful one that uses
ceiling_dirs
.