-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Node.js and vscode #19194
base: master
Are you sure you want to change the base?
Update Node.js and vscode #19194
Conversation
e29475c
to
9b47e1c
Compare
https://eslint.org/docs/latest/use/configure/migration-guide might help here, but you've probably found it already. |
Yeah, just was struggling with it at 3 am. I'll fix it 😅 |
Some proposals must have been merged Via 'product.json#extensionEnabledApiProposals' extension 'ms-vscode.vscode-selfhost-test-provider' wants API proposal 'attributableCoverage' but that proposal DOES NOT EXIST. |
I removed the vscode update and now I'm getting a different error in the same test: Via 'product.json#extensionEnabledApiProposals' extension 'ms-dotnettools.dotnet-interactive-vscode' wants API proposal 'languageConfigurationAutoClosingPairs' but that proposal DOES NOT EXIST. Likely, the proposal has been finalized (check 'vscode.d.ts') or was abandoned. it seems like it is trying to use extensions such as copilot chat in the test? |
ok, new vscode is actually working now |
I can reproduce this error on my windows machine. I don't really know where this is coming from. There is a missing |
wow, I can't believe I actually figured out where that bug was happening. there we go! |
I hate javascript |
@lnicola I think this is ready for your review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Will merge this tomorrow.
any
stuff because I don't know if it can be fixed