Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node.js and vscode #19194

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

BenjaminBrienen
Copy link
Contributor

@BenjaminBrienen BenjaminBrienen commented Feb 21, 2025

  • Updated Node to 22
  • Use flat eslint config
  • Use recommended eslint configs
  • Make lints and prettier play nice with each other
  • Update code to follow lints
    • Ignored some any stuff because I don't know if it can be fixed
  • Updated deps
  • Added jiti because it is required for TS config

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 21, 2025
@lnicola
Copy link
Member

lnicola commented Feb 21, 2025

https://eslint.org/docs/latest/use/configure/migration-guide might help here, but you've probably found it already.

@BenjaminBrienen
Copy link
Contributor Author

Yeah, just was struggling with it at 3 am. I'll fix it 😅

@BenjaminBrienen BenjaminBrienen changed the title Update Node.js and package.json deps Update Node.js and everything that entails Feb 23, 2025
@BenjaminBrienen
Copy link
Contributor Author

Some proposals must have been merged

Via 'product.json#extensionEnabledApiProposals' extension 'ms-vscode.vscode-selfhost-test-provider' wants API proposal 'attributableCoverage' but that proposal DOES NOT EXIST.

@BenjaminBrienen BenjaminBrienen changed the title Update Node.js and everything that entails Update Node.js and vscode Feb 23, 2025
@BenjaminBrienen BenjaminBrienen changed the title Update Node.js and vscode Update Node.js Feb 23, 2025
@BenjaminBrienen
Copy link
Contributor Author

I removed the vscode update and now I'm getting a different error in the same test:

Via 'product.json#extensionEnabledApiProposals' extension 'ms-dotnettools.dotnet-interactive-vscode' wants API proposal 'languageConfigurationAutoClosingPairs' but that proposal DOES NOT EXIST. Likely, the proposal has been finalized (check 'vscode.d.ts') or was abandoned.
Via 'product.json#extensionEnabledApiProposals' extension 'github.copilot

it seems like it is trying to use extensions such as copilot chat in the test?

@BenjaminBrienen BenjaminBrienen changed the title Update Node.js Update Node.js and vscode Feb 23, 2025
@BenjaminBrienen
Copy link
Contributor Author

ok, new vscode is actually working now

@BenjaminBrienen
Copy link
Contributor Author

Error: Only URLs with a scheme in: file, data, node, and electron are supported by the default ESM loader. On Windows, absolute paths must be valid file:// URLs. Received protocol 'd:'

I can reproduce this error on my windows machine. I don't really know where this is coming from. There is a missing file:// somewhere in windows-specific code, I guess.

@BenjaminBrienen
Copy link
Contributor Author

wow, I can't believe I actually figured out where that bug was happening. there we go!

@BenjaminBrienen
Copy link
Contributor Author

I hate javascript

@BenjaminBrienen
Copy link
Contributor Author

@lnicola I think this is ready for your review :)

Copy link
Member

@lnicola lnicola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Will merge this tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants