Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial take on configuring client authentication certificates #128

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

djc
Copy link
Member

@djc djc commented Jul 5, 2021

This pretty much adapts the server-side support to the client.

This is the Rust side of #123. @icing can you work with this?

@icing
Copy link
Collaborator

icing commented Jul 5, 2021

Looks good. Will start a branch to test it.👍🏻

@djc
Copy link
Member Author

djc commented Jul 5, 2021

Feel free to just reuse this branch.

@icing
Copy link
Collaborator

icing commented Jul 5, 2021

Used this PR as patch against main and implemented machine certificate configuration in mod_tls,
so the server can authenticate against proxied backends via client certificates.

Code and test cases in https://github.com/abetterinternet/mod_tls/tree/icing/machine-certs

Will merge this when rustls-ffi make a release with this feature. Many thanks!

This pretty much adapts the server-side support to the client.
@djc djc force-pushed the client-set-auth-keys branch from c8c4598 to c1b9cc3 Compare July 5, 2021 12:20
Copy link
Collaborator

@icing icing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well in my mod_tls adaption and test suite.

@icing icing merged commit 4dd38e2 into rustls:main Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants