Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give a better error message for UnexpectedEof #284

Merged
merged 2 commits into from
Mar 13, 2023
Merged

Give a better error message for UnexpectedEof #284

merged 2 commits into from
Mar 13, 2023

Conversation

jsha
Copy link
Collaborator

@jsha jsha commented Feb 10, 2023

No description provided.

cpu
cpu approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change LGTM. Could it be merged?

The two failures in CI (one, two) were caused by a sprintf usage in the test server that was fixed separately in #285

@jsha jsha merged commit 55df122 into main Mar 13, 2023
@jsha jsha deleted the better-unexpected-eof-error branch March 13, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsha @cpu