error: adapt rustls_result for upstream changes. #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpu
force-pushed
the
cpu-297-rustls_result-update
branch
from
7c2b6ba to
d0e4af9
Compare
cpu
force-pushed
the
cpu-297-rustls_result-update
branch
from
d0e4af9 to
2f9b3d4
Compare
cpu
force-pushed
the
cpu-297-rustls_result-update
branch
from
2f9b3d4 to
c02b806
Compare
cpu
force-pushed
the
cpu-297-rustls_result-update
branch
from
c02b806 to
96e62ba
Compare
5 tasks
jsha
reviewed
Mar 23, 2023
This commit adapts the `rustls_result` enum based on the changes upstream. Notably the `CertInvalidEncoding`, `CertInvalidSignatureType` and `CertInvalidData` errors have been folded into a new `CertificateError` enum that we expand out into its possible variants. Similarly the `CorruptMessage` and `CorruptMessagePayload` types have been replaced by a `InvalidMessage` enum that we expand out.
cpu
force-pushed
the
cpu-297-rustls_result-update
branch
from
96e62ba to
fe82f27
Compare
jsha
pushed a commit
that referenced
this pull request
Mar 29, 2023
This commit adapts the `rustls_result` enum based on the changes upstream. Notably the `CertInvalidEncoding`, `CertInvalidSignatureType` and `CertInvalidData` errors have been folded into a new `CertificateError` enum that we expand out into its possible variants. Similarly the `CorruptMessage` and `CorruptMessagePayload` types have been replaced by a `InvalidMessage` enum that we expand out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adapts the
rustls_resultenum based on the changes upstream. Notably theCertInvalidEncoding,CertInvalidSignatureTypeandCertInvalidDataerrors have been folded into a newCertificateErrorenum that we expand out into its possible variants. Similarly theCorruptMessageandCorruptMessagePayloadtypes have been replaced by aInvalidMessageenum that we expand out.Resolves #297.