doc: document handling of dynamically sized types #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
cpu
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
This looks great! I just had a couple small nits to flag.
I think extensive coverage of the try_xxx macros is probably too much detail, but maybe it would be worth a brief mention of their existence to direct an interested reader to their location in lib.rs? WDYT?
This is a good idea but I don't think it's tightly bound to the DSTs explanation so I'll do it in a followup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on the conversation in #341 (comment) about how to handle
Arc<dyn Foo>in the Rustls API. I decided to document this in the CONTRIBUTING.md; we can link to this sub-heading as needed.