run clippy on tests, fix findings #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
warning: redundant pattern matching, consider using `is_err()`
--> src/lib.rs:247:17
|
247 | assert!(matches!(userdata_get(), Err(_)));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `userdata_get().is_err()`
```
```
warning: used `assert_eq!` with a literal bool
--> src/client.rs:647:9
|
647 | / assert_eq!(
648 | | rustls_connection::rustls_connection_is_handshaking(conn),
649 | | true
650 | | );
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
```
```
1163 | impl rustls_server_cert_verifier {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#items_after_test_module
= note: `#[warn(clippy::items_after_test_module)]` on by default
= help: move the items to before the test module was defined
```
```
warning: use of `expect` followed by a function call
--> tests/client_server.rs:192:14
|
192 | .expect(&format!("failed to run server binary {server_binary}"))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("failed to run server binary {server_binary}"))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
= note: `#[warn(clippy::expect_fun_call)]` on by default
```
```
warning: this boolean expression can be simplified
--> tests/client_server.rs:161:22
|
161 | let passed = result.status.success() == !self.expect_error;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `result.status.success() != self.expect_error`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
= note: `#[warn(clippy::nonminimal_bool)]` on by default
```
This ensures test code is also linted.
ctz
approved these changes
Apr 5, 2024
jsha
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over in the rustls-openssl-compat repo that we bootstrapped from this repo's settings I noticed we weren't linting test code (rustls/rustls-openssl-compat#6). It looks like that's true for this repo as well.
This branch updates the clippy jobs to do so and fixes the findings that were present.