pkg-config.yml: fix typo #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpu
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
(However the job worked anyway, so maybe this step could be removed?)
I think maybe that's a better option (but will approve this fix in case you disagree). I must have overlooked that macos-latest includes pkg-config 0.29.2 in the base image.
Thanks!
This was not necessary, and was actually unconditionally skipped.
cpu
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Install pkg-config (macOS)" step was always skipped (see eg https://github.com/rustls/rustls-ffi/actions/runs/10701958885/job/29669050520) because "runner.os" has possible values "Linux", "Windows", "macOS". I think
matrix.oswas intended here.(However the job worked anyway, so maybe this step could be removed?)