Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed: Holidays not visible on calendar #1945

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Fixed: Holidays not visible on calendar #1945

wants to merge 4 commits into from
+98 −76

Conversation

Shruti-Apte
Copy link
Contributor

@Shruti-Apte Shruti-Apte commented Jan 14, 2025 •
edited
Loading

Issue:

  • No marked holidays are visible on holiday calendar (pink and grey circle )

RCA:

  • The changes made in the holiday controller earlier caused this issue. (from PR: 1830)

Fix:

  • Updated code on the frontend according to the changes made in the API.

Preview

Before:
Screenshot 2025-01-14 at 4 11 18 PM

After:
Screenshot 2025-01-14 at 4 23 42 PM

@Shruti-Apte Shruti-Apte marked this pull request as ready for review January 14, 2025 11:02
@JijoBose
Copy link
Contributor

Please fix the failing tests

JijoBose
JijoBose reviewed Feb 11, 2025
View reviewed changes
Copy link
Contributor

@JijoBose JijoBose left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix the failed tests

Update the Rails version to

gem "rails", "~> 7.1.5.1"

and then run

bundle install

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JijoBose JijoBose JijoBose approved these changes

@apoorv1316 apoorv1316 Awaiting requested review from apoorv1316

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shruti-Apte @JijoBose