Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instance): server create with additional volumes sbs #4329

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Dec 4, 2024

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


@Codelax Codelax added enhancement instance Instance issues, bugs and feature requests labels Dec 4, 2024
@Codelax Codelax force-pushed the fix/instance-server-create-additional-volumes-sbs branch from 6a45a5d to 670f020 Compare December 5, 2024 13:55
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 72.86822% with 35 lines in your changes missing coverage. Please review.

Project coverage is 70.96%. Comparing base (5bf53e0) to head (8dc559f).
Report is 377 commits behind head on master.

Files with missing lines Patch % Lines
...spaces/instance/v1/custom_server_create_builder.go 77.57% 17 Missing and 7 partials ⚠️
...nal/namespaces/instance/v1/custom_server_create.go 50.00% 8 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4329      +/-   ##
==========================================
- Coverage   75.45%   70.96%   -4.50%     
==========================================
  Files         202      294      +92     
  Lines       44323    65462   +21139     
==========================================
+ Hits        33444    46454   +13010     
- Misses       9653    17377    +7724     
- Partials     1226     1631     +405     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Codelax Codelax marked this pull request as ready for review December 5, 2024 16:05
@remyleone remyleone added this pull request to the merge queue Dec 12, 2024
Merged via the queue into scaleway:master with commit fc9456f Dec 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement instance Instance issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants