Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(instance): default server creation to ip=none #4352

Merged
merged 5 commits into from
Dec 12, 2024

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Dec 11, 2024

No description provided.

@Codelax Codelax added instance Instance issues, bugs and feature requests tests labels Dec 11, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 70.86%. Comparing base (5bf53e0) to head (ea87cf1).
Report is 387 commits behind head on master.

Files with missing lines Patch % Lines
core/testing.go 0.00% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4352      +/-   ##
==========================================
- Coverage   75.45%   70.86%   -4.60%     
==========================================
  Files         202      294      +92     
  Lines       44323    65435   +21112     
==========================================
+ Hits        33444    46368   +12924     
- Misses       9653    17446    +7793     
- Partials     1226     1621     +395     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Codelax Codelax force-pushed the tests/instance-ip-none branch from 417eabb to 8c095a4 Compare December 11, 2024 15:52
@Codelax Codelax requested a review from remyleone as a code owner December 11, 2024 16:53
@remyleone remyleone added this pull request to the merge queue Dec 12, 2024
Merged via the queue into scaleway:master with commit 21fe18d Dec 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
instance Instance issues, bugs and feature requests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants