test: move type assertion helpers to testhelpers package #4357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codelax
force-pushed
the
test/type-assertion-helpers
branch
from
cde41bc to
abd0dda
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4357 +/- ##
==========================================
- Coverage 75.45% 70.88% -4.57%
==========================================
Files 202 295 +93
Lines 44323 65494 +21171
==========================================
+ Hits 33444 46428 +12984
- Misses 9653 17436 +7783
- Partials 1226 1630 +404 ☔ View full report in Codecov by Sentry. |
remyleone
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added helpers to core/testing in a previous PR to help use write tests. I moved these helpers to testhelpers to avoid adding more to core.
I also used these new helpers in some instance tests.
The goal of those helpers is to limit test crashing. If a test crash, it will stop the whole test suite. If we make tests fail on failed type assertions, the rest of the test suite will still run.