Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(applesilicon): add support for vpc #4462

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

Laure-di
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


@Laure-di Laure-di requested a review from remyleone as a code owner January 27, 2025 11:53
@github-actions github-actions bot added the apple-silicon Apple Silicon issues, bugs and feature requests label Jan 27, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 78.10945% with 44 lines in your changes missing coverage. Please review.

Project coverage is 70.81%. Comparing base (5bf53e0) to head (9eb7f50).
Report is 456 commits behind head on master.

Files with missing lines Patch % Lines
...mespaces/applesilicon/v1alpha1/applesilicon_cli.go 78.10% 40 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4462      +/-   ##
==========================================
- Coverage   75.45%   70.81%   -4.65%     
==========================================
  Files         202      299      +97     
  Lines       44323    66350   +22027     
==========================================
+ Hits        33444    46985   +13541     
- Misses       9653    17714    +8061     
- Partials     1226     1651     +425     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remyleone remyleone changed the title feate(applesilicon): enable vpc option feat(applesilicon): enable vpc option Jan 27, 2025
@remyleone remyleone changed the title feat(applesilicon): enable vpc option feat(applesilicon): add support for vpc Jan 27, 2025
@remyleone remyleone added this pull request to the merge queue Jan 27, 2025
Merged via the queue into scaleway:master with commit 0859838 Jan 27, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apple-silicon Apple Silicon issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants