lvm: improve completions for lvremove
#1335
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should have a completion for `/dev/mapper` path. Signed-off-by: Siteshwar Vashisht <[email protected]>
|
This is a fix for https://bugzilla.redhat.com/show_bug.cgi?id=2317249. You can test it by running |
Boomtokn
approved these changes
Feb 20, 2025
akinomyoga
requested changes
Feb 20, 2025
| @@ -33,6 +33,8 @@ _comp_cmd_lvm__logicalvolumes() | |||
| for i in "${!COMPREPLY[@]}"; do | |||
| [[ ${COMPREPLY[i]} == */control ]] && unset -v 'COMPREPLY[i]' | |||
| done | |||
| elif [[ $cur == /d* ]]; then | |||
| COMPREPLY+="/dev/mapper" | |||
There was a problem hiding this comment.
This will append the string /dev/mapper to the first completion, which would result in a result e.g. /dev/vg0/gfslv/dev/mapper when a completion /dev/vg0/gfslv is already generated.
Also, shouldn't we complete /dev/mapper/ instead of /dev/mapper?
In addition, we already have the utility of "check prefix & add to COMPREPLY". We shouldn't do that manually. For the present change, you can simply _comp_compgen -- -W '/dev/mapper'. However, we already call _comp_compgen_split on line 28, so we can simply add /dev/mapper/ at the end of line 29.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should have a completion for
/dev/mapperpath.