How to generate JS file on CI environment?

[hakunin]

Hi,
in my tests that require the views to be rendered I get these:

  5) App::BoardsController regular user doesn't see boards he's not part of
     Failure/Error: get :index
     ActionView::Template::Error:
       couldn't find file 'generated/vendor-bundle'
         (in /home/ubuntu/hubstaff-projects/app/assets/javascripts/application.js:7)
     # ./app/views/layouts/application.haml:17:in `_app_views_layouts_application_haml__1848313640771384837_121778940'
     # ./spec/controllers/app/boards_controller_spec.rb:163:in `block (3 levels) in <top (required)>'

Is there a command I can run to make sure the files are there before the test starts?

[hakunin]

So I added

test:
  pre:
    - cd client && npm run build:client

into my circle.yml file which helped fix the rspecs, but cucumber complains

   Given I am logged in as Luke Skywalker                   # features/step_definitions/user_steps.rb:2
      One or more errors were raised in the Javascript code on the page. If you don't care about these errors, you can ignore them by setting js_errors: false in your Poltergeist configuration (see documentation for details).

      Error: Cannot find module "babel-runtime/core-js/json/stringify"
      Error: Cannot find module "babel-runtime/core-js/json/stringify"
          at http://127.0.0.1:56815/assets/generated/app-bundle.js?body=1:186 in webpackMissingModule
          at http://127.0.0.1:56815/assets/generated/app-bundle.js?body=1:186
          at http://127.0.0.1:56815/assets/generated/vendor-bundle.js?body=1:52 in __webpack_require__
          at http://127.0.0.1:56815/assets/generated/app-bundle.js?body=1:68
          at http://127.0.0.1:56815/assets/generated/vendor-bundle.js?body=1:52 in __webpack_require__
          at http://127.0.0.1:56815/assets/generated/app-bundle.js?body=1:14
          at http://127.0.0.1:56815/assets/generated/vendor-bundle.js?body=1:52 in __webpack_require__
          at http://127.0.0.1:56815/assets/generated/app-bundle.js?body=1:5
          at http://127.0.0.1:56815/assets/generated/vendor-bundle.js?body=1:52 in __webpack_require__
          at http://127.0.0.1:56815/assets/generated/vendor-bundle.js?body=1:23 in webpackJsonpCallback
          at http://127.0.0.1:56815/assets/generated/app-bundle.js?body=1:34301 (Capybara::Poltergeist::JavascriptError)
      ./features/step_definitions/user_steps.rb:7:in `/^I am logged in as (.+)$/'
      ./features/support/env.rb:120:in `call'
      ./features/support/env.rb:120:in `block (2 levels) in <top (required)>'
      ./features/support/env.rb:71:in `block in <top (required)>'
      features/board/card_specification.feature:11:in `Given I am logged in as Luke Skywalker'

Not sure if that generated file is somehow incorrect or what is happening. Locally it works fine.

[justin808]

@hakunin We added specific code in v3 to solve this issue. See the docs here: https://github.com/shakacode/react_on_rails/blob/master/docs%2Fadditional_reading%2Frspec_configuration.md

Please let me know if this fixes the issue.

[hakunin]

Unfortunately, it didn't.

I updated to V3, added the config line and removed the cd client && npm run build:client, and I get this:

    Failure/Error: post :update, organization: {
     ActionView::Template::Error:
       couldn't find file 'generated/vendor-bundle'
         (in /home/ubuntu/hubstaff-projects/app/assets/javascripts/application.js:7)

[justin808]

Is this only on CI?

can you repro locally?

[hakunin]

Only on CI.

On Thu, Feb 18, 2016 at 12:24 PM Justin Gordon notifications@github.com
wrote:

Is this only on CI?

can you repro locally?

—
Reply to this email directly or view it on GitHub
#281 (comment)
.

S pozdravem, Regards
Michal Hantl

skype id: michal.hantl
cell phone: +420 720 737 902

[justin808]

We've had these issues before. You'll have to yak shave with CI.

I will say, try this:

Make a fresh git clone and follow all the steps you have for CI locally.

9 out of 10 cases we see an issue we thought was only CI.

[hakunin]

More investigation:

• I updated all packages I could to new versions
• I updated npm on the CI to 4.3

During compile I get:

rake assets:precompile
cd client && npm run build:client

> react-webpack-rails-tutorial@1.1.0 build:client /home/ubuntu/hubstaff-projects/client
> NODE_ENV=production webpack --config webpack.client.rails.config.js

Webpack production build for Rails
Hash: 1a2b03e71b9c8205e3ab
Version: webpack 1.12.13
Time: 8883ms
           Asset     Size  Chunks             Chunk Names
   app-bundle.js  1.23 MB       0  [emitted]  app
vendor-bundle.js   557 kB       1  [emitted]  vendor
   [0] multi app 28 bytes {0} [built]
   [0] multi vendor 76 bytes {1} [built]
    + 372 hidden modules

ERROR in ./~/react-on-rails/node_package/lib/ReactOnRails.js
Module not found: Error: Cannot resolve module 'babel-runtime/core-js/object/assign' in /home/ubuntu/hubstaff-projects/client/node_modules/react-on-rails/node_package/lib
 @ ./~/react-on-rails/node_package/lib/ReactOnRails.js 3:14-60

ERROR in ./~/react-on-rails/node_package/lib/ReactOnRails.js
Module not found: Error: Cannot resolve module 'babel-runtime/core-js/json/stringify' in /home/ubuntu/hubstaff-projects/client/node_modules/react-on-rails/node_package/lib
 @ ./~/react-on-rails/node_package/lib/ReactOnRails.js 7:17-64

...

Any ideas? I can see from npm install on CI that the package is in fact installed.

I can affect pretty much anythign in the CI so if you have any suggestion I am able to run it.

[hakunin]

Good news @justin808, I had a missing dependency babel-runtime (which is required by react on rails) and now it compiles. Maybe you can add it as dependency by default, since it won't compile otherwise?

[justin808]

hmmm...

@hakunin We don't have that here: https://github.com/shakacode/react-webpack-rails-tutorial/blob/master/client/package.json

Maybe you can research a bit more on the specific case of why you need it?

We're using Travis for CI, so that's pretty standard.

[hakunin]

It is needed by polyfill.

babel-polyfill@6.5.0 node_modules/babel-polyfill
├── babel-regenerator-runtime@6.5.0
├── babel-runtime@5.8.35
└── core-js@1.2.6

My limited node knowledge leads me to believe that its a peer dependency, thus not installed unless you specify you want it and Travis has the package available globally.

[MindRave]

@justin808, same here. Needed the 'babel-runtime' package, otherwise bundle wouldn't compile. Don't know why this happened exactly. On one machine everything worked fine, on the other one it wouldn't without this package. Curious.

[justin808]

babel-runtime will be need for very old CI envs maybe.

Any details on when and why this is needed? Maybe the node version matters? Or the babel version?